All active workspaces are deleted all at once when using the keyboard.

[apolopena]

Bug description

If I acknowledge the deletion of a workspace using the keyboard, every single active workspace I have is deleted simultaneously.

Steps to reproduce

In the workspace dashboard:

• Have any number of workspaces in any state
• Have the filter dropdown set to either Active or All

1. Click the hambuger for a workspace and choose delete
2. Acknowledge the deletion using the keyboard

All workspaces are deleted.

Expected behavior

Only the workspace the user chooses should be deleted.

Example repository

Gitpod username: apolopena

Example 1 Video

Example 2 Video

[gtsiolis]

Great catch @apolopena! I can reproduce this. Will push for a fix within the current milestone. 🥇

[akosyakov]

resolved by #3945

[apolopena]

The way this bug was fixed introduces a new bug.
Please let me know if you want me to file it or if we can address it here.

Hitting the enter key when there is a choice to make, especially in a modal means the the user is saying "Yes" to that choice/prompt. In this case, with this fix, hitting enter closes the modal without taking action. This is indeed a bug as the expected action is to delete the workspace since the user just said "Yes" by hitting enter.

[gtsiolis]

Thanks for noticing @apolopena! Yes, feel free to open a new issue if you can concretly describe this as a bug. The plan it to tackle more accessibility and interaction issues including this one in the upcoming iterations. 🏓

Footnote: It's prefereable to avoid reopening closed issues and instead consider opening new ones for future improvements. This can be beneficial in many ways like making us move faster and better. 💡