Skip to content

[Teams] Disallow team names that are also user names or that conflict with dashboard URLs #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
jankeromnes opened this issue Jun 10, 2021 · 4 comments · Fixed by #5131
Closed
2 tasks
Assignees
Labels
roadmap item: teams & projects type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

When creating a new Team, one should not be able to give it a name such that:

  • It's called the same as / looks like a user
  • Its gitpod.io/:slug URL conflicts with an existing dashboard URL (e.g. "Workspaces" should be forbidden)

As specified in #4355

Follow-up to #4401

@corneliusludmann
Copy link
Contributor

Is it planned to use a blocklist as well to prevent team names like admin, support etc? There are a lot of lists out there, e.g. https://github.com/marteinn/The-Big-Username-Blocklist.

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 5, 2021

Cross-posting a comment from a relevant discussion (internal):

question: Would it be worth it to reconsider generating team and project URLs with a random hash suffix or prefix attached?
Like:

gitpod.io/team-o9yti4go/project-1bik3oxv/

or

gitpod.io/team/o9yti4go/team-name/ +
gitpod.io/project/1bik3oxv/project-name/

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Aug 6, 2021

I personally think this looks much less nice. I'm quite happy to have https://github.com/jankeromnes, and would find GitHub much less nice if I had to use https://github.com/jankeromnes-o9yti4go instead.

@gtsiolis-o9yti4go what do you think? 😇

@jankeromnes jankeromnes self-assigned this Aug 9, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 9, 2021

@jankeromnes your call! Posted the comment in #4469 (comment) in case it could make this issue obsolete or redundant. In terms of UX or Product both options could suffice. Looking forward to see how this implementation will work in action. 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap item: teams & projects type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants