Skip to content

[projects] Fix workspace/project association when based on a prebuild #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jankeromnes opened this issue Oct 8, 2021 · 8 comments · Fixed by #6117
Closed

[projects] Fix workspace/project association when based on a prebuild #6116

jankeromnes opened this issue Oct 8, 2021 · 8 comments · Fixed by #6117
Assignees
Labels
feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. priority: highest (user impact) Directly user impacting team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 8, 2021

Bug description

Follow-up to #6071 and #6097

When starting a workspace without a prebuild, the Project association is now correct.

However, when starting a workspace based on a prebuild, it automatically gets associated to the same Project as the prebuild (which can be a now-deleted Project, a project you're not a member of, or an older Prebuild without a project):

projectId: context.prebuiltWorkspace.projectId,

Steps to reproduce

  1. Open a workspace on a repository that has a prebuild associated to a Project you don't have access to (e.g. https://gitlab.com/AlexTugarev/testing5888 if you're not Alex), or an older prebuild that has no Project associated (e.g. https://github.com/gitpod-io/browser-extension)

Expected behavior

No response

Example repository

No response

Anything else?

No response

@jankeromnes jankeromnes added type: bug Something isn't working feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Oct 8, 2021
@jankeromnes
Copy link
Contributor Author

/schedule

@roboquat
Copy link
Contributor

roboquat commented Oct 8, 2021

@jankeromnes: Cannot schedule issue - issue does not belong to a team. Use /team to specify one.

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jankeromnes
Copy link
Contributor Author

/team meta

@roboquat roboquat added the team: webapp Issue belongs to the WebApp team label Oct 8, 2021
@jankeromnes
Copy link
Contributor Author

/schedule

@roboquat
Copy link
Contributor

roboquat commented Oct 8, 2021

@jankeromnes: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jankeromnes
Copy link
Contributor Author

/assign @AlexTugarev

@jankeromnes
Copy link
Contributor Author

/state in-review

@jankeromnes
Copy link
Contributor Author

/status in-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. priority: highest (user impact) Directly user impacting team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants