Skip to content

[Admin] Search for projects and show project details #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
12 of 15 tasks
Tracked by #7597
laushinka opened this issue Jan 17, 2022 · 7 comments · Fixed by #7882
Closed
12 of 15 tasks
Tracked by #7597

[Admin] Search for projects and show project details #7636

laushinka opened this issue Jan 17, 2022 · 7 comments · Fixed by #7882
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team

Comments

@laushinka
Copy link
Contributor

laushinka commented Jan 17, 2022

Admin page should allow searching of projects by entering the repo or the slug.

(The following screenshot is just a placeholder - this will need more design decisions)
Screenshot 2022-01-17 at 11 13 21

Search

  • sub-string match anywhere in the cloneUrl (assuming this is possible, and OK for DB performance)
  • nice-to-have: match on slug

Search results

  • list entries show name (link to project detail), cloneUrl (link to git provider)
  • list ordered by created date
  • list ordered by updated date

Project details

  • page URL is /admin/projects/project-id
  • name
  • repository (from cloneUrl)
  • incremental prebuilds (from settings)
  • owner
  • team
  • created date
  • list of prebuilds

Prebuild details

  • page URL is /admin/prebuilds/prebuild-id
  • same content (with prebuild log) as in projects UI
@laushinka laushinka moved this to Scheduled in 🍎 WebApp Team Jan 17, 2022
@laushinka laushinka moved this from Scheduled to Needs Design in 🍎 WebApp Team Jan 17, 2022
@laushinka laushinka changed the title search for project by repo or slug (prefix search) Search for project by repo or slug (prefix search) Jan 17, 2022
@laushinka laushinka moved this from Needs Design to Scheduled in 🍎 WebApp Team Jan 18, 2022
@laushinka laushinka moved this from Scheduled to In Progress in 🍎 WebApp Team Jan 18, 2022
@gtsiolis gtsiolis self-assigned this Jan 18, 2022
@jldec jldec changed the title Search for project by repo or slug (prefix search) Search for projects and show project details Jan 19, 2022
@jldec jldec changed the title Search for projects and show project details [Admin] Search for projects and show project details Jan 25, 2022
@laushinka
Copy link
Contributor Author

With Prebuilds No Prebuilds
Screenshot 2022-01-27 at 12 33 38 Screenshot 2022-01-27 at 12 33 31

@laushinka
Copy link
Contributor Author

laushinka commented Jan 27, 2022

@jldec @gtsiolis How Project Detail looks like in progress 👆🏼

@laushinka
Copy link
Contributor Author

@jldec @gtsiolis And this is what the search list looks like in progress:
Screenshot 2022-01-27 at 12 35 53

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 27, 2022

Thanks for the update, @laushinka! I'm posting below the current state of the designs, after catching up with @jldec earlier today, see relevant document (internal). Feedback is welcome!

Projects List Project Details
Projects (List) Projects (Details)

@laushinka
Copy link
Contributor Author

laushinka commented Jan 27, 2022

I'm posting below the current state of the designs, after catching up with @jldec earlier today

@gtsiolis Thanks! Some questions:

  1. Where would we put the information on incremental prebuilds and whether it's deleted?
  2. Do teams also have an avatar? In case the owner is a team?

I also wonder whether this new design layout can be implemented later for all of the user and workspace details in the same ticket, so we have a consistent look in one release?

@jldec In the tasks list in the description, we have the prebuild details as well. Do we want this in this ticket too? Or should this ticket be the MVC for the project search? Reusing the components are not that straightforward, as every method call needs to be created and adjusted for admin actions as well. I'm fine with working on them, but also would be happy to see the most important things shipped.

@jldec
Copy link
Contributor

jldec commented Jan 28, 2022

I looked at the current implementation with @laushinka using the implementation in #7882

  • The project list with 3 columns: name, cloneUrl, and created, works well
    Let's keep that design for now, and switch to name-above-with-git-provider/org-below in a separate ticket when we have a consistent way to do that across lists.
  • Similarly, the project detail which follows the layout from workspaces, and includes user and team in 2 separate values, works well. We can upgrade to a user-or-team pattern later.
  • The prebuild detail can be added separately - for this first implementation just showing the prebuild list below the project is already a big step forward for admins.

@gtsiolis
Copy link
Contributor

Thanks, @laushinka @jldec! Agree with #7636 (comment). Just posted some review comments in #7882 (review).

Repository owner moved this from In Progress to Done in 🍎 WebApp Team Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants