Skip to content

[Admin] Search for team by name or slug and show team details #8060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
13 tasks done
Tracked by #7597
jldec opened this issue Feb 7, 2022 · 7 comments · Fixed by #8402
Closed
13 tasks done
Tracked by #7597

[Admin] Search for team by name or slug and show team details #8060

jldec opened this issue Feb 7, 2022 · 7 comments · Fixed by #8402
Assignees
Labels
feature: admin dashboard team: webapp Issue belongs to the WebApp team

Comments

@jldec
Copy link
Contributor

jldec commented Feb 7, 2022

From discussion[1](internal):

Search for teams

  • by name

  • by slug (helpful for team names with funny characters)

  • Results - order by created desc

    • Name + team URL (/t/slug) underneath
    • Created date (order by desc) show arrow in heading
    • Indicate deleted (nice to have in admin lists)
  • Click on any result (entire row is clickable) to go to team detail

Team detail

  • Team name + team URL at the top

  • Other fields:

    • created date (either friendly with actual date/time on hover, or actual date/time)
    • mark deleted
    • member count
  • Member list

    • (Not required for deleted teams)
    • List columns: Member, Joined, Role
    • Paginated would be nice OR ok to limit list + Search for now
    • Click to link to user detail
    • Nice to have actions: change role (useful for support to assign new owner)

Future

  • More actions
    • Rename (should be possible for non-admin users as well - complexity with slug rename)
    • Delete
    • Invite URL (@laushinka moved this from nice-to-have to a future task)
  • Project list
    • toggled with member list using tab-like component
@jldec
Copy link
Contributor Author

jldec commented Feb 10, 2022

@gtsiolis
Please see MVC spec for new team admin pages above.
Happy to take addditional suggestions from you if you have.

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 22, 2022

While working this, I'm taking a stab at re-ordering some of the navigation structure in favor of some upcoming dashboard navigation changes in #8385 in case these could be part of this issue. However, going with the existing layout pattern could suffice for this MVC (minimum viable change) iteration.

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 22, 2022

Posting below some specs that reuse existing patterns from the admin dashboard. Future iterations will probably re-order some of the navigation elements, see #8385.

Teams List Team Details Team Details (Deleted)
Teams (List) Team (Details) Team (Details)-1

See design specs.

@laushinka
Copy link
Contributor

Posting below

@gtsiolis Thank you! I was a bit uninspired when thinking of what the team details should look like, and this looks good. Are the possible actions for each team member the same as the current actions? i.e. Leave Team or Remove

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 22, 2022

@laushinka Yes, I swinged between re-using the existing tabular pattern of the project detail page but also tabs to separate overview, members, and projects. However, I think going with a (simple) boring solution here like the proposal in #8060 (comment) sounds good for the first iteration.

🅰️ Things to consider dropping:

  1. The more actions on members (Leave team, etc)
  2. The invite team members button
  3. The search button from the search form. Long-term we will most probably build an overview dashboard page that links to all sub-entities including listing recently added entries by default instead of having empty pages like we have now for users, projects, teams, etc.

To answer your question, I'd drop the members actions. Cc @jldec

🅱️ Things to consider adding:

  1. Members count as we do in the team scope selector in the top navigation.
  2. Option to delete a team, see relevant screenshot from the users in admin below.
  3. Re-using the label component for the soft deletion indicator.
  4. Better interaction to go back to search results or all entries list. Food for thought. 🍔
Blocked user label with option to delete
Screenshot 2022-02-22 at 5 00 48 PM

@laushinka
Copy link
Contributor

@gtsiolis @jldec Feel free to play around in the draft PR to get early thoughts 🙏🏽

@jldec
Copy link
Contributor Author

jldec commented Feb 23, 2022

Looks good thanks @laushinka - adjusted description with additional tasks.

@laushinka laushinka moved this to In Progress in 🍎 WebApp Team Feb 23, 2022
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: admin dashboard team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants