[telemetry] Wrong enable service ping state in admin dashboard after login #8344
Assignees
Labels
feature: admin dashboard
team: delivery
Issue belongs to the self-hosted team
type: bug
Something isn't working
Comments
corneliusludmann
added
type: bug
corneliusludmann
moved this to 🧊Backlog
in 🚚 Security, Infrastructure, and Delivery Team (SID)
corneliusludmann
moved this from 🧊Backlog
to 📓Scheduled
in 🚚 Security, Infrastructure, and Delivery Team (SID)
corneliusludmann
moved this from 📓Scheduled
to 🤝Proposed
in 🚚 Security, Infrastructure, and Delivery Team (SID)
Pothulapati
added a commit
that referenced
this issue
Feb 22, 2022
Fixes #8344 `Enable Service Ping` seems to be set to `false` by defaut until the UI is re-loaded. This fixes it by also adding the retrieval logic into `useEffect` thereby calling it everytime, even during initial render. Signed-off-by: Tarun Pothulapati <[email protected]>
corneliusludmann
moved this from 🤝Proposed
to ⚒In Progress
in 🚚 Security, Infrastructure, and Delivery Team (SID)
Pothulapati
added a commit
that referenced
this issue
Feb 24, 2022
Fixes #8344 `Enable Service Ping` seems to be set to `false` by defaut until the UI is re-loaded. This fixes it by also adding the retrieval logic into `useEffect` thereby calling it everytime, even during initial render. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this issue
Feb 24, 2022
Fixes #8344 `Enable Service Ping` seems to be set to `false` by defaut until the UI is re-loaded. This fixes it by also adding the retrieval logic into `useEffect` thereby calling it everytime, even during initial render. Signed-off-by: Tarun Pothulapati <[email protected]>
roboquat
pushed a commit
that referenced
this issue
Feb 24, 2022
Fixes #8344 `Enable Service Ping` seems to be set to `false` by defaut until the UI is re-loaded. This fixes it by also adding the retrieval logic into `useEffect` thereby calling it everytime, even during initial render. Signed-off-by: Tarun Pothulapati <[email protected]>
Repository owner
moved this from ⚒In Progress
to ✨Done
in 🚚 Security, Infrastructure, and Delivery Team (SID)
Feb 24, 2022
mustard-mh
pushed a commit
that referenced
this issue
Feb 28, 2022
Fixes #8344 `Enable Service Ping` seems to be set to `false` by defaut until the UI is re-loaded. This fixes it by also adding the retrieval logic into `useEffect` thereby calling it everytime, even during initial render. Signed-off-by: Tarun Pothulapati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I log in to Gitpod (Self-Hosted) and go to Admin → Settings, the “Enable Service Ping” checkbox is not checked (which seems to be wrong). When I reload the page, the checkbox is checked (which is correct). That happens only directly after login. When I navigate away (after the reload) and back to this page the state of the checkbox is correct.
The text was updated successfully, but these errors were encountered: