-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Change "Search workspaces" to "Enter workspace ID" and disable contextURL search. #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Cc-ing @geropl in case you disagree or have other thoughts 🙏🏽 |
@laushinka Thx for the ping.
Thoughts:
|
@gtsiolis I'll probably need your design input for a search dropdown 🙏🏽 |
@laushinka I've added this to product design board to take a look later. |
@gtsiolis Thanks! And it doesn't have to be a dropdown, something like a search with radio buttons would also work? |
Breaking down the issue, here're some thoughts:
Taking the above into account, changing the backend to search only across workspaces names (IDs) as described in the issue sounds good. However, I agree that the placeholder Search Workspaces sounds a bit abstract and could be misleading but also currently follows the pattern we're using across the product for all search inputs. What we could also do is either keep the input placeholder as is or improve this by rephrasing the placeholder to be more explicit. For example, using Search by workspace name or simply Search by name sounds like an improvement. What do you think? Cc @laushinka @geropl
Sorry for the lengthy comment! 😇 |
@gtsiolis Thanks for the comprehensive comment! Definitely a lot coming down the road and that's good to know. So the minimum changes here we can make are:
|
If I understand your question correctly, should we allow searching for emails on the workspaces list? I haven't run into that usecase, but if there is please let me know.
This was also a question I had - what admins actually need to search on regarding workspaces. It seems that usually when there are customer issues, we ask for their workspace IDs and contextURL to investigate (Gero and Jürgen can correct me if I'm wrong). Down the road we can allow contextURLs again, but for now workspace IDs should suffice. |
Regarding #8453 (comment):
@laushinka I was playing devil's advocate here. I also think this is not a useful or valid use case. 😈
I think just the workspace name (ID) suffices when it comes to customer support but I could be wrong. Cc @geropl @jldec Regarding #8453 (comment):
|
IMO workspaceId is by far the most important one, so fine to take that approach as MVC. |
Thanks, @geropl! Makes sense and probably would solve 90% of the use cases, right? Later on we could introduce better ways to debug or discover workspace instance IDs from the admin dashboard while browsing workspace IDs, too. |
Workspace ID search returns quite fast, and searches usually do use the workspace IDs.
Therefore we will only allow workspace ID searches and disable the free text search.
The text was updated successfully, but these errors were encountered: