Skip to content

[installer] Make type and annotations of the services configurable #8838

Closed
@nandajavarma

Description

@nandajavarma

Is your feature request related to a problem? Please describe

The type of the Service resources in the YAML produced by the installer should be configurable from the config. This is due to the reason that we have different requirement of this depending on which kind of installation the user is going for (workspace vs full vs meta).
For eg., In workspace only installation, since ws-proxy is the entrypoint we have to use LoadBalancer type as the service type but at the same time, the user might prefer to stick with ClusterIP in cases like usage of an ingress controller. This means that, the user will have to post-process the YAML created by the installer which can be very inconvenient.

Describe the behaviour you'd like

The ServiceType and ServiceAnnotations should be configurable. It can be added to the experimental section of the installer config for now to avoid official support.

Describe alternatives you've considered

Currently, in the installer the type of the services of proxy and ws-proxy are hardcoded to LoadBalancer in the corresponding InstallerKinds. Moreover, we hardcode the annotations for service like cloud.google.com/neg for LoadBalancer type services, necessity for GCP.
This PR hardcodes ServiceType for ws-proxy in workspace installation,

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    component: installTerraform installation scripts, helm charts, installer imagesinstaller: needs interface changeChange required to input, output or configuration file(s)meta: staleThis issue/PR is stale and will be closed soonteam: deliveryIssue belongs to the self-hosted team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions