Skip to content

Improve review process for Team Workspace API Components #8981

Closed
@kylos101

Description

@kylos101

Is your feature request related to a problem? Please describe

A few folders for Workspace components require approval from explicit individuals. [1][2][3]

This can create bottlenecks for the team. As an experiment, we'd like to try using lazy consensus.

Describe the behaviour you'd like

With great power comes great responsibility. 🕷️ 👨

For the Team Workspace components mentioned above (APIs):

  1. Replace @csweichel and @aledbf for 3 workspace APIs with @gitpod-io/engineering-workspace .
  2. When teammates add approval for a PR containing API changes, the approval message must contain two things:
    *. /LGTM
    *. /hold for 28 hours as lazy consensus <-- to allow time for the team to consider the PR as a whole.

Describe alternatives you've considered

Leave @aledbf as approver for the three components, but, replace approval from @csweichel with :

  1. ws-daemon-api -> @Furisto
  2. ws-manager-api -> @sagor999

Additional context

Ref: Slack

Metadata

Metadata

Assignees

Labels

team: workspaceIssue belongs to the Workspace team

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions