Skip to content

Improve automated PR description for JetBrains auto-update #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2022
Merged

Improve automated PR description for JetBrains auto-update #10003

merged 1 commit into from
May 13, 2022

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented May 13, 2022 •
edited
Loading

Description

Improving the "how-to-test" section

How to

Before After
Screenshot 2022-05-13 at 14 27 42 Screenshot 2022-05-13 at 14 26 16

Release Notes

NONE

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented May 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

I spent good 5 minutes trying to find where to update this template. If we only listened to @gtsiolis.. 😜

@andreafalzetti andreafalzetti requested a review from a team May 13, 2022 12:30
akosyakov
akosyakov reviewed May 13, 2022
View reviewed changes
@akosyakov
Copy link
Member

@andreafalzetti Can we add team: IDE label too?

@akosyakov akosyakov requested a review from mustard-mh May 13, 2022 12:41
mustard-mh
mustard-mh reviewed May 13, 2022
View reviewed changes
mustard-mh
mustard-mh reviewed May 13, 2022
View reviewed changes
mustard-mh
mustard-mh reviewed May 13, 2022
View reviewed changes
@andreafalzetti andreafalzetti force-pushed the afalz/jb-pr-desc-update branch from 5fce93d to d6d7efe Compare May 13, 2022 13:24
@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented May 13, 2022 •
edited
Loading

@andreafalzetti Can we add team: IDE label too?

it looks like that the label team: IDE gets already added by github-actions bot: #9969 (comment)

Is this what you mean? @akosyakov

@andreafalzetti andreafalzetti force-pushed the afalz/jb-pr-desc-update branch 3 times, most recently from d4faaaa to 69cd299 Compare May 13, 2022 13:34
mustard-mh
mustard-mh reviewed May 13, 2022
View reviewed changes
@andreafalzetti andreafalzetti force-pushed the afalz/jb-pr-desc-update branch from 69cd299 to 20a83d3 Compare May 13, 2022 14:00
mustard-mh
mustard-mh approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to unhold

/hold

akosyakov
akosyakov reviewed May 13, 2022
View reviewed changes
akosyakov
akosyakov reviewed May 13, 2022
View reviewed changes
akosyakov
akosyakov reviewed May 13, 2022
View reviewed changes
@andreafalzetti andreafalzetti force-pushed the afalz/jb-pr-desc-update branch from 20a83d3 to ef0fb3a Compare May 13, 2022 15:04
@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented May 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/unhold

Thanks @mustard-mh @akosyakov 🙏

@roboquat roboquat merged commit 3359591 into main May 13, 2022
@roboquat roboquat deleted the afalz/jb-pr-desc-update branch May 13, 2022 15:10
@roboquat roboquat added the deployed: IDE IDE change is running in production label May 17, 2022
@roboquat roboquat added the deployed Change is completely running in production label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@mustard-mh mustard-mh mustard-mh approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/S team: IDE
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreafalzetti @akosyakov @mustard-mh @roboquat