Skip to content

[baseserver] Initialize go metrics automatically #10050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 16, 2022

Description

Automatically initialize go metrics against the baseserver registry - removes extra thing to remember.

Related Issue(s)

Fixes #

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested review from a team May 16, 2022 19:38
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels May 16, 2022
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! I left a comment.

@easyCZ easyCZ force-pushed the mp/baseserver-init-metrics branch from d603efd to 73cb046 Compare May 17, 2022 05:18
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat roboquat merged commit ebdff1f into main May 17, 2022
@roboquat roboquat deleted the mp/baseserver-init-metrics branch May 17, 2022 05:44
@roboquat roboquat added the deployed: webapp Meta team change is running in production label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/M team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants