Skip to content

Replace UA logo #10110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

Replace UA logo #10110

merged 1 commit into from
May 19, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented May 18, 2022

Description

This will replace the UA logo and add a message in the bottom right corner of the loading screen (workspace start).

  • The placement is due to the already packed elements stacked vertically in the middle of the screen, which would cause the message to disappear on smaller viewports.
  • The style was changed to be more subtle so that it's not conflicting with the existing information architecture and hierarchy of the workspace start page.
  • Instead of the 🇺🇦 flag emoji, a subtle and generic custom SVG icon was used with the colors of the 🇺🇦 flag emoji, inspired from the dashboard status indicator for workspaces, integrations, and more.

See also relevant discussion (internal).

Related Issue(s)

Fixes #10088 #8484

How to test

Open a new workspace and notice the logo replacement as well as the message on in the bottom right corner of the loading screen (workspace start). 🇺🇦

Screenshots

BEFORE AFTER
Screenshot 2022-05-19 at 12 19 34 AM (2) Screenshot 2022-05-19 at 12 18 56 AM (2)
Screenshot 2022-05-19 at 12 19 29 AM (2) Screenshot 2022-05-19 at 12 18 46 AM (2)

Alternatively, we could replace the custom SVG icon with the 🇺🇦 flag emoji.

Example with the 🇺🇦 flag emoji (Light) Example with the 🇺🇦 flag emoji (Dark)
Screenshot 2022-05-19 at 12 25 48 AM (2) Screenshot 2022-05-19 at 12 25 53 AM (2)

Release Notes

NONE

Cc @chrifro @atduarte @ghuntley because #10088
Cc @jldec because #8484

@gtsiolis gtsiolis requested a review from a team May 18, 2022 21:28
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 18, 2022
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 4f881b7 into main May 19, 2022
@roboquat roboquat deleted the gt/replace-ua-logo branch May 19, 2022 11:18
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Gitpod logo on loading screen
3 participants