Skip to content

[public-api] Fix kube-rbac-proxy upstream metrics port #10115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 19, 2022

Description

In the refactor from #9999, we did not update the metrics port from Debug to a newly added MetricsPort. This fixes the upstream for kube rbac to correctly get metrics

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested a review from a team May 19, 2022 07:37
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 19, 2022
@roboquat roboquat merged commit 099769c into main May 19, 2022
@roboquat roboquat deleted the mp/public-api-fix-metrics-port branch May 19, 2022 08:31
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants