Skip to content

[public-api] Align command structure with other servers #10117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

[public-api] Align command structure with other servers #10117

merged 1 commit into from
May 19, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 19, 2022 •
edited
Loading

Description

This PR is a subset of #10009 to align public api with other packages

Related Issue(s)

Fixes #

How to test

cd dev/gpctl

go run main.go api workspaces get --id 123 --token foo --address  api.mp-public-ba9a8fb89b.preview.gitpod-dev.com:443 

# Expect to get an L7 response - Invalid credentials - this is success because the service continues to run
INFO[0000] Establishing gRPC connection against api.mp-public-ba9a8fb89b.preview.gitpod-dev.com:443 
FATA[0000] Failed to retrieve workspace.                 error="failed to retrieve workspace (ID: 123): rpc error: code = PermissionDenied desc = insufficient permission to access workspace"
exit status 1

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested a review from a team May 19, 2022 08:15
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 19, 2022
@easyCZ easyCZ force-pushed the mp/public-api-align-cli-setup branch from 378c5ef to 30da9f3 Compare May 19, 2022 08:16
@easyCZ easyCZ force-pushed the mp/public-api-align-cli-setup branch from 30da9f3 to 01ce220 Compare May 19, 2022 08:23
@easyCZ easyCZ mentioned this pull request May 19, 2022
Merged
@roboquat roboquat merged commit 51450d5 into main May 19, 2022
@roboquat roboquat deleted the mp/public-api-align-cli-setup branch May 19, 2022 08:57
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @andrew-farries @roboquat