[baseserver] fix CI lint failed #10161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
sagor999
approved these changes
May 20, 2022
|
@sagor999 I guess it related with golang version, golangci-lint version actual, If you don't use the previous version of the dev image, the build will always error out https://github.com/gitpod-io/gitpod/runs/6450784405?check_suite_focus=true |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #10157 is merge, all builds is failed because below error, see detail in https://werft.gitpod-dev.com/job/gitpod-build-main.3323
This PR fixes that, This is just a simplified fix, I see that the comments say that you also need to exit if you receive a server error, but I haven't had time to read the code yet @andrew-farries
Related Issue(s)
Fixes #
How to test
see werft job is pass
Release Notes
Documentation