-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Reduce the memory requests for workspaces #10191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of context that I realise might be missing. The Gitpod Installer (the source in /install/installer
) is used to Install Gitpod in general. We use it in preview environment, but also in SaaS and Self-Hosted. So we have to be careful about making changes to the config, and in this case we just want to change the config of Gitpod in preview environments.
To change resource requests for workspaces in preview environments you'd want to make the change in the Werft job where we're generating (and modifying) the configuration file for the Gitpod Installer, rather in the Gitpod Installer itself.
For workspaces that change would be here
gitpod/.werft/jobs/build/installer/installer.ts
Lines 107 to 110 in e148325
private configureWorkspaces(slice: string) { | |
exec(`yq w -i ${this.options.installerConfigPath} workspace.runtime.containerdRuntimeDir ${CONTAINERD_RUNTIME_DIR}`, { slice: slice }); | |
exec(`yq w -i ${this.options.installerConfigPath} workspace.resources.requests.cpu "100m"`, { slice: slice }); | |
} |
/werft run 👍 started the job as gitpod-build-aa-ws-resources.6 |
Thanks for the context! This makes sense. Eventually I tried to remove the resource requests from the the |
ab9ccf2
to
61d6659
Compare
Description
Reduce the memory requests for workspaces. This should allow for more workspaces to fit in preview envs.
Related Issue(s)
Fixes #10028