Skip to content

[jb] enable connect button only when JetBrains Client not activated (cont.) #10216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[jb] enable connect button only when JetBrains Client not activated (cont.) #10216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions ...ns/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
import com.intellij.ide.BrowserUtil
import com.intellij.openapi.Disposable
import com.intellij.openapi.components.service
import com.intellij.openapi.diagnostic.Logger
import com.intellij.openapi.diagnostic.thisLogger
import com.intellij.remote.RemoteCredentialsHolder
import com.intellij.remoteDev.util.onTerminationOrNow
import com.intellij.ssh.AskAboutHostKey
import com.intellij.ssh.OpenSshLikeHostKeyVerifier
import com.intellij.ssh.connectionBuilder
Expand All @@ -35,7 +35,6 @@ import com.jetbrains.gateway.ssh.ClientOverSshTunnelConnector
import com.jetbrains.gateway.thinClientLink.ThinClientHandle
import com.jetbrains.rd.util.URI
import com.jetbrains.rd.util.lifetime.Lifetime
import com.jetbrains.rd.util.lifetime.isAlive
import com.jetbrains.rd.util.lifetime.onTermination
import io.gitpod.gitpodprotocol.api.entities.WorkspaceInstance
import io.gitpod.jetbrains.icons.GitpodIcons
Expand All @@ -58,7 +57,20 @@ class GitpodConnectionProvider : GatewayConnectionProvider {
private val gitpod = service<GitpodConnectionService>()

companion object {
var jetbrainsClientMap: MutableMap<String, ThinClientHandle> = mutableMapOf()
private var jetbrainsClientMap: MutableMap<String, ThinClientHandle> = mutableMapOf()

private fun setClient(workspaceId: String, client: ThinClientHandle?) {
if (client != null) {
jetbrainsClientMap[workspaceId] = client
} else {
jetbrainsClientMap.remove(workspaceId)
}
dispatcher.multicaster.didChange()
}

fun getClient(workspaceId: String): ThinClientHandle? {
return jetbrainsClientMap[workspaceId]
}

private val dispatcher = EventDispatcher.create(Listener::class.java)

Expand Down Expand Up @@ -259,27 +271,20 @@ class GitpodConnectionProvider : GatewayConnectionProvider {
)
val client = connector.connect()
client.clientClosed.advise(connectionLifetime) {
thisLogger().d("clientClosed, ${client.prettyPrint()}")
application.invokeLater {
connectionLifetime.onTermination {
thisLogger().d("clientTermination, clientClosed didChange fired, ${client.prettyPrint()}")
dispatcher.multicaster.didChange()
}
connectionLifetime.terminate()
}
}
client.onClientPresenceChanged.advise(connectionLifetime) {
thisLogger().d("presenceChanged, ${client.prettyPrint()}")
application.invokeLater {
thisLogger().d("clientPresenceChanged didChange fired, ${client.prettyPrint()}")
dispatcher.multicaster.didChange()
if (client.clientPresent) {
statusMessage.text = ""
}
}
}
thinClient = client
jetbrainsClientMap[update.workspaceId] = client
setClient(update.workspaceId, client)
client.lifetime.onTerminationOrNow { setClient(update.workspaceId, null) }
} catch (t: Throwable) {
if (t is CancellationException) {
throw t
Expand All @@ -289,6 +294,7 @@ class GitpodConnectionProvider : GatewayConnectionProvider {
t
)
setErrorMessage("" + t.message)
setClient(update.workspaceId, null)
}
}
}
Expand Down Expand Up @@ -478,11 +484,3 @@ class GitpodConnectionProvider : GatewayConnectionProvider {
private data class SSHHostKey(val type: String, val hostKey: String)

}

fun ThinClientHandle.prettyPrint(): String {
return "uid=${uid}, clientPresent=${clientPresent}, lifeTime={status=${lifetime.status}, alive=${lifetime.isAlive}}"
}

fun Logger.d(message: String) {
thisLogger().info("[jb-gw] $message")
}
16 changes: 5 additions & 11 deletions ...brains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodWorkspacesView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,7 @@ class GitpodWorkspacesView(
init {
refresh()
loggedIn.addListener { refresh() }
GitpodConnectionProvider.addListener {
thisLogger().d("WorkspaceView refresh, " +
GitpodConnectionProvider.jetbrainsClientMap
.map { "[wsId=${it.key}, ${it.value.prettyPrint()}]" }
.joinToString("; "))
refresh()
}
GitpodConnectionProvider.addListener { refresh() }
}

private fun startUpdateLoop(lifetime: Lifetime, workspacesPane: JBScrollPane): () -> Unit {
Expand Down Expand Up @@ -300,9 +294,9 @@ class GitpodWorkspacesView(
)
}
label(getRelativeTimeSpan(info.latestInstance.creationTime))
val jbClientConnected = GitpodConnectionProvider.jetbrainsClientMap[info.workspace.id]
?.lifetime?.isAlive ?: false
val btnText = if (jbClientConnected) "Connected" else "Connect"
val client = GitpodConnectionProvider.getClient(info.workspace.id)
val connected = client?.lifetime?.isAlive ?: false
val btnText = if (connected) "Connected" else "Connect"
button(btnText) {
if (!canConnect) {
BrowserUtil.browse(info.latestInstance.ideUrl)
Expand All @@ -314,7 +308,7 @@ class GitpodWorkspacesView(
)
)
}
}.enabled(!jbClientConnected)
}.enabled(!connected)
cell()
}.layout(RowLayout.PARENT_GRID)
}
Expand Down