Skip to content

[dev] Separate ssh IP and ws-proxy IP #10221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022
Merged

[dev] Separate ssh IP and ws-proxy IP #10221

merged 1 commit into from
May 25, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 24, 2022

Description

In #9786 we introduce a special domain for ssh gateway
This PR change harvester base preview environment use this special domain
This has some benefit

  1. Save some money, before, accessing workspace pages also required the use of loadbalancer, which consumed some unnecessary traffic, after this PR, all non-SSH traffic will no longer go through loadbalancer
  2. To improve some stability, kubectl port-forward is not very stable, for example, vm sometimes need to rebuild, then kubectl will time out, and the pod will restart, this restart time will have exponential growth, we do not want to bring this instability to the users who do not use SSH Gateway

Related Issue(s)

Fixes #

How to test

  1. start a workspace, open browser IDE it should work
  2. connect with ssh, it should be work too

Release Notes

NONE

Documentation

@iQQBot
Copy link
Contributor Author

iQQBot commented May 24, 2022

wait this PR approved #10222

@iQQBot iQQBot marked this pull request as ready for review May 25, 2022 02:51
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roboquat roboquat merged commit 80bb697 into main May 25, 2022
@roboquat roboquat deleted the pd/dev-ssh branch May 25, 2022 10:29
@iQQBot iQQBot self-assigned this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants