Skip to content

Support more containerd runtime dir #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022
Merged

Support more containerd runtime dir #10237

merged 1 commit into from
May 25, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

This PR adds support to auto-detect another containerd runtime which is commonly found in Amazon Linux.

Related Issue(s)

Fixes #10103

How to test

Release Notes

None

Documentation

@nandajavarma nandajavarma requested a review from a team May 25, 2022 07:23
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label May 25, 2022
Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛹

@roboquat roboquat merged commit bd1c6d6 into main May 25, 2022
@roboquat roboquat deleted the nvn/fix-10103 branch May 25, 2022 07:43
@nandajavarma
Copy link
Contributor Author

In a future iteration, we will make the containerd runtime dir detection more automated. We could pgrep the containerd process and look at the flags in cmdline. Internal

Follow-up issue: [installer] Improve automated detection of containerdRuntimeDir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kots] Support /run/containerd/io.containerd.runtime.v2.task/k8s.io as ContainerDRuntimeDir in KOTS installer
3 participants