Skip to content

Add CertManager's cmctl to dev env #10240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2022
Merged

Add CertManager's cmctl to dev env #10240

merged 1 commit into from
May 25, 2022

Conversation

meysholdt
Copy link
Member

@meysholdt meysholdt commented May 25, 2022 •
edited by mustard-mh
Loading

Description

Add CertManager's cmctl to the dev env. This helps to debug cert renewal and to manually renew certs.

see https://cert-manager.io/docs/usage/cmctl/

more context: https://gitpod.slack.com/archives/C01KGM9EBD4/p1652698881554549?thread_ts=1652432265.637629&cid=C01KGM9EBD4

Related Issue(s)

Fixes #

How to test

  1. Open this PR with gitpod.io
  2. Run cmctl

Release Notes

NONE

Documentation

@roboquat roboquat added size/S and removed size/XS labels May 25, 2022
@meysholdt meysholdt marked this pull request as ready for review May 25, 2022 08:50
@meysholdt meysholdt requested review from a team May 25, 2022 08:50
@github-actions github-actions bot added team: IDE team: devx team: workspace Issue belongs to the Workspace team labels May 25, 2022
@mustard-mh mustard-mh mentioned this pull request May 25, 2022
Merged
1 task
@mustard-mh
Copy link
Contributor

mustard-mh commented May 25, 2022 •
edited
Loading

Werft job failed, need this PR #10243 to be merged and cherry-picked to fix

mustard-mh
mustard-mh approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase to main if you want to test in preview env build success

@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@meysholdt
Copy link
Member Author

Thx for the pointer @mustard-mh! I've rebased this PR on main.

mustard-mh
mustard-mh reviewed May 25, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Tested

mads-hartmann
mads-hartmann approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛹

@roboquat roboquat merged commit 60f7e21 into main May 25, 2022
@roboquat roboquat deleted the me/cmctl branch May 25, 2022 10:27
@roboquat roboquat added the deployed: IDE IDE change is running in production label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustard-mh mustard-mh mustard-mh approved these changes

@mads-hartmann mads-hartmann mads-hartmann approved these changes

@andrew-farries andrew-farries andrew-farries approved these changes

@princerachit princerachit princerachit approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production release-note-none size/S team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@meysholdt @mustard-mh @mads-hartmann @andrew-farries @princerachit @roboquat