Skip to content

[licensor] update fn parameter in license validator #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

nandajavarma
Copy link
Contributor

Description

In #10069 we updated the replicated evaluator to not do domain name validation. Unfortunately I missed to cleanup the function call in the validator code. This fixed the issue. Alongside, this removes a break statement which is reduntant since it is implicit in Go.

Related Issue(s)

Fixes #

How to test

The biggest effect this issue had was throwing a Problem in the editor when you open a workspace, this will remove the error.

Release Notes

None

Documentation

@nandajavarma nandajavarma requested a review from a team May 25, 2022 14:26
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 25, 2022
@roboquat roboquat merged commit 9fa1375 into main May 25, 2022
@roboquat roboquat deleted the nvn/fix-licval branch May 25, 2022 16:05
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants