Skip to content

Revert "[jb] enable connect button only when JetBrains Client not activated" #10279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2022
Merged

Revert "[jb] enable connect button only when JetBrains Client not activated" #10279

merged 1 commit into from
May 27, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented May 26, 2022 •
edited
Loading

Reverts #10177 as suggested by @akosyakov in #10216 (comment):

I wonder is it really a solution? You can still get with multiple connection windows while workspace is starting or stopping?

I still was able to cause such conditions as from browser as from GW if i click several times while workspace is starting. I think the proper fix is to ensure that there is only connection at the time, not a client.

Release Notes

NONE

@felladrin felladrin requested a review from a team May 26, 2022 11:49
@felladrin felladrin mentioned this pull request May 26, 2022
Closed
1 task
akosyakov
akosyakov reviewed May 26, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

akosyakov
akosyakov approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roboquat roboquat merged commit d09d677 into main May 27, 2022
@roboquat roboquat deleted the revert-10177-jb-gw branch May 27, 2022 06:53
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note-none size/M team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felladrin @akosyakov @roboquat