[usage] Harden parsing of time from VarChar field #10390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
May 31, 2022
| return nil | ||
| case string: | ||
| if len(s) == 0 { | ||
| n.valid = false |
There was a problem hiding this comment.
We wouldn't necessarily need to do this as false is the default value, but it's here mostly for ease of reading.
easyCZ
force-pushed
the
mp/usage-db-varchartime
branch
from
ae48e03 to
45f1ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A consequence of using VarChar to store datetimes is that the varchar can be empty as well. This is handled on the TS side as optional but in Go, we need something akin to
sql.NullStringto handle this case.This PR extends the VarCharTime struct to handle this case by setting validity and exposes methods to check if the value was set.
Related Issue(s)
Fixes #
How to test
Unit tests
Release Notes
Documentation
NONE