Skip to content

[ws-manager] show why pod entered completed state #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2022
Merged

[ws-manager] show why pod entered completed state #10414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc15994
[ws-manager] show why pod entered completed state
sagor999 Jun 1, 2022
45f33bf
Update components/ws-manager/pkg/manager/status.go
sagor999 Jun 2, 2022
a5f4a03
Update status_wsstartup_Creating00.golden
sagor999 Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ws-manager/pkg/manager/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ func extractFailure(wso workspaceObjects) (string, *api.WorkspacePhase) {
// default way for headless workspaces to be done
return "", nil
}
return fmt.Sprintf("container %s completed; containers of a workspace pod are not supposed to do that", cs.Name), nil
return fmt.Sprintf("container %s completed; containers of a workspace pod are not supposed to do that. Reason: %s", cs.Name, terminationState.Message), nil
} else if !isPodBeingDeleted(pod) && terminationState.ExitCode != containerUnknownExitCode {
// if a container is terminated and it wasn't because of either:
// - regular shutdown
Expand Down
2 changes: 1 addition & 1 deletion components/ws-manager/pkg/manager/testdata/status_wsstartup_Creating00.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"phase": 3,
"conditions": {
"failed": "container sync completed; containers of a workspace pod are not supposed to do that",
"failed": "container sync completed; containers of a workspace pod are not supposed to do that. Reason: ",
"volume_snapshot": {}
},
"message": "workspace initializer is running",
Expand Down