[bridge] Extracting updating of prebuilds into PrebuildUpdater (2/3) #10425
Conversation
geropl
changed the title
geropl
force-pushed
the
gpl/9395-stuck-prebuilds-2
branch
from
ddd06f0 to
40a3e5d
Compare
|
/unhold |
roboquat
added
deployed: webapp
| @@ -462,24 +466,11 @@ export class WorkspaceManagerBridge implements Disposable { | |||
| instance.stoppedTime = new Date().toISOString(); | |||
| promises.push(this.workspaceDB.trace({}).storeInstance(instance)); | |||
| promises.push(this.onInstanceStopped({}, ri.workspace.ownerId, instance)); | |||
| promises.push(this.stopPrebuildInstance(ctx, instance)); | |||
| promises.push(this.prebuildUpdater.stopPrebuildInstance(ctx, instance)); | |||
There was a problem hiding this comment.
@geropl I don't think this does anything useful. Looks to me like it would update the workspace instance that got set to 'stopped' a few lines above now to 'aborted'. Am I missing something?
There was a problem hiding this comment.
Looks to me like it would update the workspace instance that got set to 'stopped' a few lines above now to 'aborted'. Am I missing something?
It updates the PrebuiltWorkspace that's corresponding that WorkspaceInstance to aborted, which would otherwise not bet updated.
In what context are you looking into this? Can I help?
There was a problem hiding this comment.
It updates the PrebuiltWorkspace that's corresponding that WorkspaceInstance to aborted, which would otherwise not bet updated.
Why does it do that? And how can a prebuild not be finished when there is a workspace based on it?
In what context are you looking into this? Can I help?
Just reading the code and trying to make sense of it 😇
There was a problem hiding this comment.
Ah, got it now. Forget it 😁
There was a problem hiding this comment.
What confused me is that the method is called stopPrebuildInstance while it only aborts the PrebuildWorkspace in the database.
Description
This PR extract all logic related to updating prebuilds from src/ee/bridge behind a new interface
PrebuildUpdaterwith two implementations: Noop (non-ee version) and DB (ee version) (2/3 in the chain)Related Issue(s)
Context: #9395
How to test
kubectl logs ws-manager-bridge- ws-manager-bridgeRelease Notes
Documentation