[previewctl] Improve logging #10436
Merged
[previewctl] Improve logging #10436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
reviewed
Jun 3, 2022
| @@ -8,16 +8,17 @@ import ( | |||
| "fmt" | |||
|
|
|||
| "github.com/gitpod-io/gitpod/previewctl/pkg/preview" | |||
| "github.com/go-kit/log" | |||
There was a problem hiding this comment.
All code in Gitpod uses logrus - we even tie klog (used by Kubernetes components) back to logrus.
What's the motivation to go astray? I.e. which requirements warrant the use of a different library?
There was a problem hiding this comment.
None really, just wanted to move away from the previous 🙂
I'll update the PR to logrus
There was a problem hiding this comment.
best use common-go/log, but using logrus directly is fine, too.
There was a problem hiding this comment.
I believe adopting a big lib just for one of the features may be too much.
I've only switched to logrus for now, but if someday in the future we need tracing/metrics/pprof, then common-go sounds like a good idea 🙂
ArthurSens
force-pushed
the
as/previewctl-logging
branch
from
c45c5a6 to
2203c43
Compare
Switched log library to Logrus Signed-off-by: ArthurSens <[email protected]>
ArthurSens
force-pushed
the
as/previewctl-logging
branch
from
2203c43 to
734bff4
Compare
vulkoingim
reviewed
Jun 6, 2022
vulkoingim
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve experience while debugging when previewctl is not behaving as it should, this PR does 2 things:
install-context --watchfails to install and goes for another loopHow to test
previewctl install-context --watchYou'll notice that the watch still doesn't work as expected (for me it stops looping at some point), but at least now we know what is happening 😅
Release Notes