Skip to content

Remove X-Server from Dev-Image #10438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Remove X-Server from Dev-Image #10438

merged 1 commit into from
Jun 3, 2022

Conversation

meysholdt
Copy link
Member

Description

Context: https://gitpod.slack.com/archives/C01KGM9AW4W/p1654025762967629

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

@meysholdt meysholdt requested review from a team June 2, 2022 14:29
@github-actions github-actions bot added team: IDE team: devx team: workspace Issue belongs to the Workspace team labels Jun 2, 2022
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe you can also clean up some VNC related ports from our gitpod.yml file too ☺️ https://github.com/gitpod-io/gitpod/blob/main/.gitpod.yml#L15-L20

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Jun 3, 2022

@meysholdt Added the hold label to not get Tide stuck as this needs to be rebased now ☺️

@meysholdt
Copy link
Member Author

I did the rebase. Next step: re-run the image build.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@roboquat roboquat added size/S and removed size/XS labels Jun 3, 2022
@roboquat roboquat merged commit aafb99b into main Jun 3, 2022
@roboquat roboquat deleted the me/me-image branch June 3, 2022 09:06
@roboquat roboquat added the deployed: IDE IDE change is running in production label Jun 9, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/S team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants