Skip to content

Revert "[baseserver] Change default metrics port to 9502 to not clash with kube-rbac-proxy" #10442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

Revert "[baseserver] Change default metrics port to 9502 to not clash with kube-rbac-proxy" #10442

merged 1 commit into from
Jun 2, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 2, 2022 •
edited
Loading

Reverts #10109

Revert "[baseserver] Change default metrics port to 9502 to not clash with kube-rbac-proxy"

@aledbf aledbf requested review from a team June 2, 2022 20:36
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jun 2, 2022
kylos101
kylos101 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yes please

@aledbf aledbf mentioned this pull request Jun 2, 2022
Merged
@roboquat roboquat merged commit c7077d1 into main Jun 2, 2022
@roboquat roboquat deleted the revert-10109-mp/baseserver-default-metrics-port branch June 2, 2022 20:51
@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2022

The collision issue is being fixed in #10443

@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jun 9, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @kylos101 @roboquat