[usage] Handle empty value varchar time, use ISO8601 #10490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/usage-varchar-time-serialize-des
branch
from
8a86688 to
bb6a4c2
Compare
easyCZ
commented
Jun 6, 2022
| @@ -80,9 +79,21 @@ func (n VarcharTime) IsSet() bool { | |||
|
|
|||
| // Value implements the driver Valuer interface. | |||
| func (n VarcharTime) Value() (driver.Value, error) { | |||
There was a problem hiding this comment.
This is what will be inserted into SQL statements. Here we use the ISO8601 format to be consistent with existing records.
| if n.IsSet() { | ||
| return TimeToISO8601(n.t), nil | ||
| } | ||
| return "", nil | ||
| } | ||
|
|
||
| func (n VarcharTime) String() string { |
There was a problem hiding this comment.
This is what is used to print this field for humans, when we're converting the struct to a string. We align with the DB value and also print ISO8601
easyCZ
changed the title
andrew-farries
approved these changes
Jun 7, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hardens handling of Varchar Time records in the DB. Here, we ensure that empty value of VarChar is equivalent to the empty string and therefore not a valid Timestamp, but a valid value to store in the DB.
Related Issue(s)
How to test
Unit tests (run by CI)
Release Notes
Documentation
NONE