Skip to content

Always keep preview envs on db activity #10498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Always keep preview envs on db activity #10498

merged 1 commit into from
Jun 7, 2022

Conversation

vulkoingim
Copy link
Contributor

@vulkoingim vulkoingim commented Jun 7, 2022

Description

Always keep preview environments when there is DB activity. This addresses an edge case where forks that have a running preview env would get delete due to not having a "real" branch in the repo, but might be active otherwise.

Related Issue(s)

Fixes #9891 (comment)

Release Notes

NONE

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🛹

@roboquat roboquat merged commit 5653a5e into main Jun 7, 2022
@roboquat roboquat deleted the aa/preview-env-db2 branch June 7, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview Envs on Harvester: Delete when inactive
3 participants