Skip to content

refactor(dashboard/menu): persist team selection #10603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

refactor(dashboard/menu): persist team selection #10603

wants to merge 2 commits into from

Conversation

aboqasem
Copy link

Description

Persist team selection for better UX.

Related Issue(s)

Fixes #10496

How to test

  1. Open dashboard
  2. Switch teams
  3. Click on Workspaces
  4. You should still be on your selected team
  5. Repeat 2 through 4 and optionally check local storage to see the team selection changing

Then:

  1. Visit root URL (/)
  2. The team selection should still be remembered

Release Notes

persist selected team across pages

Documentation

@aboqasem aboqasem requested a review from a team June 11, 2022 06:27
@aboqasem aboqasem marked this pull request as draft June 11, 2022 06:32
@aboqasem
Copy link
Author

aboqasem commented Jun 11, 2022 •
edited
Loading

  • Creating a new team should change the persisted team to the new created team
  • Visiting a team via URL should change the persisted team to the one in the URL
  • Deleting a team should remove the persisted team

@aboqasem
Copy link
Author

aboqasem commented Jun 11, 2022 •
edited
Loading

Now even /projects does not depend on the URL to have /t/[slug]. That is a problem AFAIK, right?

I am used to Next.js routing not to react-router, my bad 😅!

@aboqasem aboqasem changed the title refactor(menu/team-selection): persist team selection refactor(dashboard/menu): persist team selection Jun 12, 2022
@roboquat roboquat added size/L and removed size/M labels Jun 12, 2022
@aboqasem
Copy link
Author

aboqasem commented Jun 12, 2022 •
edited by werft-gitpod-dev-com bot
Loading

The current behavior I implemented is for pages to be aware of the team even if the URL does not contain the team slug. I do not know whether this is wanted 🙂

@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 14, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-improve-persist-team-selection-fork.0
(with .werft/ from main)

@stale
Copy link

stale bot commented Jun 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 24, 2022
@stale stale bot closed this Jun 29, 2022
@gtsiolis gtsiolis reopened this Jun 29, 2022
@stale stale bot closed this Jul 7, 2022
@gtsiolis gtsiolis reopened this Jul 7, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jul 7, 2022
aboqasem added 2 commits July 10, 2022 21:58
@aboqasem
refactor(menu/team-selection): persist team selection
27c70e9
@aboqasem
refactor(dashboard/menu): fix issues with team selection persistence
000eeba 
- Creating a new team should change the persisted team to the new created team
- Visiting a team via URL should change the persisted team to the one in the URL
- Deleting a team should remove the persisted team
@aboqasem aboqasem force-pushed the improve/persist-team-selection branch from 4a2eedc to 000eeba Compare July 10, 2022 13:59
@stale
Copy link

stale bot commented Jul 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 30, 2022
@stale stale bot closed this Aug 10, 2022
@gtsiolis gtsiolis reopened this Aug 10, 2022
@stale stale bot closed this Aug 16, 2022
@gtsiolis gtsiolis reopened this Aug 16, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Aug 16, 2022
@stale
Copy link

stale bot commented Sep 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@gtsiolis gtsiolis marked this pull request as ready for review September 12, 2022 09:06
@stale stale bot removed meta: stale This issue/PR is stale and will be closed soon labels Sep 12, 2022
@stale
Copy link

stale bot commented Sep 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 24, 2022
@gtsiolis gtsiolis mentioned this pull request Sep 26, 2022
Merged
3 tasks
@svenefftinge
Copy link
Member

hey @aboqasem !Super sorry this PR slipped our attention. It's now quite outdated and I didn't see it when I started on #13316 . I'll bring this up with team so we can improve our handling of contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution meta: stale This issue/PR is stale and will be closed soon release-note size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider remembering team selection when visiting pages like workspaces
4 participants
@aboqasem @gtsiolis @svenefftinge @roboquat