Skip to content

werft/build: Rename created_vm span attribute #10636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

ArthurSens
Copy link
Contributor

Description

Self-explanatory

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/2727

Release Notes

NONE

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛹

@ArthurSens
Copy link
Contributor Author

ArthurSens commented Jun 14, 2022

🛹

Was that supposed to be an approval? 😅

@mads-hartmann mads-hartmann self-requested a review June 14, 2022 09:54
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛹 (Actually approve this time)

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Jun 14, 2022

Was that supposed to be an approval? 😅

@ArthurSens haha yes, sorry!

@roboquat roboquat merged commit 2e55f9c into main Jun 14, 2022
@roboquat roboquat deleted the as/create-vm-attribute branch June 14, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants