Skip to content

Remove deprecated function grpc.WithInsecure() #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jun 15, 2022

Description

The function grpc.WithInsecure() is deprecated, use grpc.WithTransportCredentials(insecure.NewCredentials()) instead.

Related Issue(s)

Fixes #

How to test

Release Notes

None

Documentation

None

@jenting jenting requested review from a team June 15, 2022 05:33
@github-actions github-actions bot added team: IDE team: workspace Issue belongs to the Workspace team labels Jun 15, 2022
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find some with global search

IMG

@jenting jenting force-pushed the jenting/deprecated-function branch from 1b24d7c to 5c39772 Compare June 15, 2022 05:50
@roboquat roboquat added size/L and removed size/M labels Jun 15, 2022
@jenting
Copy link
Contributor Author

jenting commented Jun 15, 2022

@mustard-mh Thanks for catching up, I filtered some folders before, and I've updated them. 🙏

@jenting jenting marked this pull request as draft June 15, 2022 05:54
The function grpc.WithInsecure() is deprecated, use
grpc.WithTransportCredentials(insecure.NewCredentials()) instead.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting force-pushed the jenting/deprecated-function branch from 5c39772 to da40a3c Compare June 15, 2022 05:55
@jenting jenting marked this pull request as ready for review June 15, 2022 06:10
@jenting jenting requested a review from mustard-mh June 15, 2022 06:10
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@roboquat roboquat merged commit 9631a0b into main Jun 15, 2022
@roboquat roboquat deleted the jenting/deprecated-function branch June 15, 2022 07:37
@jenting jenting changed the title Remove deprecated function Remove deprecated function grpc.WithInsecure Jun 15, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-deprecated-function.3 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting changed the title Remove deprecated function grpc.WithInsecure Remove deprecated function grpc.WithInsecure() Jun 15, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-deprecated-function.4 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants