Opt-in preview environments #10681
Opt-in preview environments #10681
Conversation
|
started the job as gitpod-build-aa-opt-in-prevs.2 because the annotations in the pull request description changed |
|
/werft run github -j ./werft/build.yaml -a updateGitHubStatus=gitpod-io/gitpod 👍 started the job as gitpod-build-aa-opt-in-prevs.3 |
|
started the job as gitpod-build-aa-opt-in-prevs.4 because the annotations in the pull request description changed |
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
started the job as gitpod-build-aa-opt-in-prevs.5 because the annotations in the pull request description changed |
vulkoingim
force-pushed
the
aa/opt-in-prevs
branch
from
b981fe8 to
47acec2
Compare
|
started the job as gitpod-build-aa-opt-in-prevs.8 because the annotations in the pull request description changed |
|
started the job as gitpod-build-aa-opt-in-prevs.9 because the annotations in the pull request description changed |
|
started the job as gitpod-build-aa-opt-in-prevs.10 because the annotations in the pull request description changed |
|
started the job as gitpod-build-aa-opt-in-prevs.11 because the annotations in the pull request description changed |
There was a problem hiding this comment.
The changes look good!
My only concern is that this is a breaking change to everyone's workflow, but I'm not aware if there was internal discussion around it already 🤔
@meysholdt, do you think we need to bring this up during all-hands/engineering sync before merging?
Would it be less disruptive if the template had the werft with-preview checked by default and people could optionally remove it?
Well, the idea is to make them opt-in, not opt-out (see here #9899). As for announcing it - I was planning on posting in Slack once this gets merged. |
I did bring it up in an engineering sync and in the sync we found alignment to make preview ends opt-in.
I think it's good how Aleks proposed it: It's disabled by default (resource-friendly) and can easily be enabled. My assumption is that enabling it is not a burden because you get all you need from the PR template and only need to add an X. I also assume that people won't miss the X because they're redacting/enhancing what they got from the template before creating a PR. |
|
Thus let's move forward the way Aleks has proposed it: Merge this PR, Aleks announces it on Slack, and I link to Aleks announcement in the all-hands notes. |
|
started the job as gitpod-build-aa-opt-in-prevs.12 because the annotations in the pull request description changed |
vulkoingim
force-pushed
the
aa/opt-in-prevs
branch
from
0cb57e3 to
531f993
Compare
|
Thanks for shipping this, @vulkoingim! ✨ |
Description
Preview environments become optional with a toggle switch in the PR template.
The org-wide PR template is at:
https://github.com/gitpod-io/.github/blob/main/.github/pull_request_template.md
But we only care about modifying the template for this repository - therefore I've added it here and made the change.
Related Issue(s)
Fixes #9899
How to test
Job without
with-previewset: https://werft.gitpod-dev.com/job/gitpod-custom-aa-opt-in-prevs.1/logsJob with
with-previewset: https://werft.gitpod-dev.com/job/gitpod-custom-aa-opt-in-prevs.2/logsRelease Notes
Werft options: