Skip to content

Update ssh gw dashboard #10693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Update ssh gw dashboard #10693

merged 1 commit into from
Jun 16, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 16, 2022

Description

Simplify it to show most important info:

  • throughput of valid and suspicious traffic
  • total failure ratios and error ratios by kind

Related Issue(s)

Fixes #

How to test

See https://grafana.gitpod.io/d/anton-ssh/antons-ssh-gateway-overview?orgId=1&refresh=30s

Release Notes

NONE

Documentation

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-ssh-gw-dashboard.1 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov
Copy link
Member Author

@iQQBot could you review whether it is alright with you?

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akosyakov
Copy link
Member Author

LGTM, I think you can also remove this part
https://github.com/gitpod-io/gitpod/pull/10693/files#diff-8d4ba5399468d59d11fcfe4769266e5054d8c6d7a098d5961c5ffbb96c94427bR428-R453

Unfortunately link does not highlight lines. Maybe you can comment on the file?

@iQQBot
Copy link
Contributor

iQQBot commented Jun 16, 2022

{
"current": {
"selected": false,
"text": "All",
"value": "$__all"
},
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
},
"definition": "label_values(gitpod_ws_proxy_ssh_connection_count, cluster)",
"hide": 0,
"includeAll": true,
"multi": true,
"name": "cluster",
"options": [],
"query": {
"query": "label_values(gitpod_ws_proxy_ssh_connection_count, cluster)",
"refId": "StandardVariableQuery"
},
"refresh": 2,
"regex": "(?:eu|us).*",
"skipUrlSync": false,
"sort": 1,
"type": "query"
}

this, because you never use this variable
image

Simplify it to show most important info:
- throughput of valid and suspicious traffic
- total failure ratios and error ratios by kind
@akosyakov
Copy link
Member Author

akosyakov commented Jun 16, 2022

@iQQBot makes sense, updated and pushed 🙏

@akosyakov akosyakov force-pushed the ak/ssh-gw-dashboard branch from 7930e9b to 56f62ef Compare June 16, 2022 12:08
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@roboquat roboquat merged commit d3dd3be into main Jun 16, 2022
@roboquat roboquat deleted the ak/ssh-gw-dashboard branch June 16, 2022 12:15
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XXL team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants