previewctl: Wrap shell script that list VMs #10771
Conversation
|
started the job as gitpod-build-as-preview-list-vms.2 because the annotations in the pull request description changed |
| @@ -89,3 +95,46 @@ func (p *Preview) GetPreviewName() string { | |||
|
|
|||
| return sanitizedBranch | |||
| } | |||
|
|
|||
| func ListAllPreviews() error { | |||
| configLoadingRules := &clientcmd.ClientConfigLoadingRules{ExplicitPath: "/home/gitpod/.kube/config"} | |||
There was a problem hiding this comment.
I think it's safer to use the default rule. If you really want to use this explicit one - then still merging with the default one is a safer option.
There was a problem hiding this comment.
Yeah I agree, for some reason it didn't work though 🤔
I tried using:
- ~/.kube/config
- ${HOME}/.kube/config
- $HOME/.kube/config
They all fail with the same error: stat <filepath>: file or directory does not exist
The only way I was able to make this run was by using the explicit path :(
There was a problem hiding this comment.
The default path should be in $KUBECONFIG, but the package provides a way to load from well-known paths. Have a look at the godocs and the examples: https://pkg.go.dev/k8s.io/client-go/tools/clientcmd
Ultimately have one rule loading the default + this one with the explicit and then merge them together.
There was a problem hiding this comment.
Ah nice, I was not aware of those defaults. Changed the PR to use them :)
Signed-off-by: ArthurSens <[email protected]>
ArthurSens
force-pushed
the
as/preview-list-vms
branch
from
593d1ff to
cfd1185
Compare
Signed-off-by: ArthurSens [email protected]
Description
Add command
previewctl list, which lists all existing preview environments.It is done by re-implementing the shell script
dev/preview/list-vms.shbut with go and native Kubernetes go clients.Related Issue(s)
Looks like we don't have an issue for this one, but we did agree on working on this during our team-sync.
How to test
Run the command
previewctl listRelease Notes
Documentation
Werft options: