Skip to content

[installer]: document the custom annotations #10841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrsimonemms
Copy link
Contributor

Description

Documentation for the custom annotations. Based upon #10461 (comment)

Related Issue(s)

Fixes #10840

How to test

Read

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms force-pushed the sje/custom-annotations-docs branch from b2f0e66 to 8b7193f Compare June 27, 2022 15:48
@mrsimonemms mrsimonemms marked this pull request as ready for review June 27, 2022 15:52
@mrsimonemms mrsimonemms requested a review from a team June 27, 2022 15:52
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jun 27, 2022
@nandajavarma
Copy link
Contributor

nandajavarma commented Jun 28, 2022

Just wondering, should we document that the user will have to do a delete --cascade=orphan on ws-manager Deployment in the given example?
Edit: If updating an existing installation, that is.

@mrsimonemms
Copy link
Contributor Author

Just wondering, should we document that the user will have to do a delete --cascade=orphan on ws-manager Deployment in the given example? Edit: If updating an existing installation, that is.

@nandajavarma I've had a think about it and I think, that in the README at least, we probably don't want to be adding complexities. These are mostly for our team anyway.

I've made the documentation on the website more "how to get around" it. I decided against the --cascade=orphan as I don't think we should be adding that complexity if/when it goes wrong. I'd rather suggest something simple that works for customers and then they can come to us when they have specific needs

@mrsimonemms
Copy link
Contributor Author

I'm actually going to close this - we have it in the website and there's nothing unique in here

@mrsimonemms mrsimonemms deleted the sje/custom-annotations-docs branch June 28, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document for Installer
3 participants