[installer] add customCACert volume to ws-proxy
#10850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
ws-issue
branch
2 times, most recently
from
cc8cb4a to
eaf9c00
Compare
This PR adds `customCACert` volume to `ws-proxy` Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
commented
Jun 23, 2022
| }, | ||
| } | ||
|
|
||
| if vol, mnt, env, ok := common.CustomCACertVolume(ctx); ok { |
There was a problem hiding this comment.
This is the cert loading part. podSpec is separated so that its easier to do this.
sagor999
approved these changes
Jun 23, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After https://github.com/gitpod-io/gitpod/pull/10514/files#diff-b20fcd9b24f3f080dc12476d648794f320434fee1053e2195a18d2ecd38482e2R47-R49,
ws-proxygoes through theproxyto talk theide-proxy. Forself-signedinstances ofGitpod this means that
ws-proxyalso needs to trust the self-signed Cert.For that to happen, This PR starts loading the
customCACertontows-proxyalong with the necessary env variables.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: