Skip to content

[Self-Hosted] Changed preflight memory check error amount and reworded #10865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

lucasvaltl
Copy link
Contributor

Description

Changed the node memory preflight check:

  1. Changed it so that it errors on 16gb
  2. Reworded it to be about per node memory, not per cluster memory

Related Issue(s)

Fixes #10726

How to test

Release Notes

NONE

@lucasvaltl lucasvaltl requested a review from a team June 23, 2022 12:39
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jun 23, 2022
@mrsimonemms
Copy link
Contributor

That's not consistent with the public requirements - do these need to change too?

@lucasvaltl
Copy link
Contributor Author

They do - and will: https://github.com/gitpod-io/website/pull/2295

@roboquat roboquat merged commit c0ef19f into main Jun 23, 2022
@roboquat roboquat deleted the 10726/reword-cluster-memory-check branch June 23, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-Hosted installation: Resource requirement inconsistency
3 participants