Skip to content

[server] fix linting issue #10894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2022
Merged

[server] fix linting issue #10894

merged 1 commit into from
Jun 24, 2022

Conversation

svenefftinge
Copy link
Member

Description

Fixes a linting issue:

/workspace/gitpod/components/server/src/user/token-service.ts:42:13
ERROR: 42:13  no-floating-promises  Promises must be handled appropriately

Release Notes

NONE

@svenefftinge svenefftinge requested a review from a team June 24, 2022 09:40
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 24, 2022
geropl
geropl approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@roboquat roboquat merged commit 8789ee7 into main Jun 24, 2022
@roboquat roboquat deleted the se/linting-fix branch June 24, 2022 09:51
@AlexTugarev
Copy link
Member

Thanks @svenefftinge and @geropl!

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svenefftinge @AlexTugarev @geropl @roboquat