[installation-telemetry] Respect sendCustomerID admin setting
#10913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An errant `git rebase` accidentally merged in the customer ID into telemetry data, bypassing a later check in telemetry collection that checked the `sendCustomerID` field. This commit restores the appropriate check.
github-actions
bot
added
team: delivery
corneliusludmann
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An errant
git rebaseaccidentally merged in the customer ID into telemetrydata, bypassing a later check in telemetry collection that checked the
sendCustomerIDfield. This commit restores the appropriate check.
Related Issue(s)
Introduced by #10629
How to test
Go to
Admin/Settings, disable theInclude customer ID in telemetryoption, and refresh the page. The customer ID field should not be present when the checkbox is unticked.Release Notes
Documentation
NONE
Werft options: