Skip to content

[supervisor-frontend] add track for sent closed heartbeat #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

[supervisor-frontend] add track for sent closed heartbeat #10970

merged 1 commit into from
Jun 28, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jun 28, 2022 •
edited
Loading

Description

[supervisor-frontend] add track for sent closed heartbeat

Related Issue(s)

Fixes #

How to test

  1. start a workspace
  2. close browser tab
  3. monitor in segment, it should send a ide_close_signal event

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Jun 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-hw-track-hb.1
(with .werft/ from main)

@mustard-mh mustard-mh force-pushed the hw/track-hb branch 3 times, most recently from 11bc845 to d5ba5cb Compare June 28, 2022 10:44
@akosyakov akosyakov requested a review from iQQBot June 28, 2022 12:21
akosyakov
akosyakov reviewed Jun 28, 2022
View reviewed changes
akosyakov
akosyakov reviewed Jun 28, 2022
View reviewed changes
@mustard-mh mustard-mh marked this pull request as ready for review June 28, 2022 12:50
@mustard-mh mustard-mh requested a review from a team June 28, 2022 12:50
@akosyakov
Copy link
Member

Code-wise it looks good, but some reasons I don't see anything in segment for stable VS Code. Should I use latest?

akosyakov
akosyakov approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@roboquat roboquat merged commit 490419b into main Jun 28, 2022
@roboquat roboquat deleted the hw/track-hb branch June 28, 2022 13:05
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

@iQQBot iQQBot Awaiting requested review from iQQBot

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/S team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustard-mh @akosyakov @roboquat