-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Provide endpoint for getting workspace classes from cluster #10982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c40d6fd
to
a59860e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold
for a comment regarding potentially missing json block. Feel free to unhold if that json block is not necessary there.
a59860e
to
0469475
Compare
0469475
to
8de0906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes in self-hosted owned files look good
Hey @aledbf, can you take a look please? |
/unhold |
Description
Adds an endpoint to ws-manager that allows to retrieve the workspace classes that are supported by the cluster. This will be called by the meta cluster side. The information returned is the identifier and the name of the workspace class. The name is what is displayed to the user and the id is what will be used to refer to the class internally. That way we can change the name without having to update internal references.
Related Issue(s)
Partially fixes ##10842
How to test
I used this simple test program. You need to get the tls config from ws-manager first using gpctl clusters get-tls-config. Port-forward ws-manager to 12001 and then execute
test --tls ./ws-man
Release Notes
Werft options: