Skip to content

[supervisor] Check if git repository is shallow before running --unshallow #10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 29, 2022

Description

https://git-scm.com/docs/git-rev-parse

Related Issue(s)

xref: https://cloudlogging.app.goo.gl/iaodaYmM7HfTDpwq8

How to test

  • Start a workspace
  • Stop the workspace and wait until is not running
  • Reopen the workspace
  • Check workspace logs and check it does not contain:
    fatal: --unshallow on a complete repository does not make sense

Release Notes

NONE

@jeanp413
Copy link
Member

Thanks @aledbf, but do you know why we get this error? As far as I know we always do a shallow clone and then unshallow so does this mean we are unshallowing twice (or more times) 🤔 ?

@aledbf
Copy link
Member Author

aledbf commented Jun 29, 2022

Thanks @aledbf, but do you know why we get this error? As far as I know we always do a shallow clone and then unshallow so does this mean we are unshallowing twice (or more times) thinking ?

I think this happens when you restart a workspace. I can see jsonPayload.source="from-backup" (which makes sense)

@aledbf
Copy link
Member Author

aledbf commented Jun 29, 2022

/hold

@aledbf
Copy link
Member Author

aledbf commented Jun 29, 2022

/hold cancel

@jeanp413
Copy link
Member

From the logs I see this error started happening on may 29th, maybe the root cause is somewhere else, will take a quick look just to be sure

@roboquat roboquat merged commit 65384db into main Jun 29, 2022
@roboquat roboquat deleted the aledbf/super branch June 29, 2022 04:33
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/S team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants