[alerts] fix pod/container/namespace not rendering #11060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because every time series is uniquely identified by its metric name a set of labels, and every unique combination of key-value label pairs represents a new alert for this time series. There is no common value for these metrics - kube_pod_container_status_restarts_total - gitpod_ws_manager_workspace_backups_failure_total Signed-off-by: JenTing Hsiao <[email protected]>
sagor999
approved these changes
Jul 1, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because every time series is uniquely identified by its metric name and a set of labels, every unique combination of key-value label pairs represents a new alert for this time series.
There is no common value for these metrics
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
None
Werft options: