Skip to content

Use omitempty struct tag in baseserver config #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Add an omitempty struct tag to the TLS field in the baseserver config. This makes it slightly easier to write tests against.

Related Issue(s)

See this comment on #11224

How to test

Release Notes

NONE

/hold

@andrew-farries andrew-farries requested review from a team July 8, 2022 14:23
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jul 8, 2022
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/unhold

@roboquat roboquat merged commit 22f51dd into af/initial-usage-api-impl Jul 11, 2022
@roboquat roboquat deleted the af/omit-empty-tls-spec branch July 11, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants