-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ws-manager] Add event to workspace Pod when the PVC restored from the VolumeSnapshot #11367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
/werft run -a with-preview=true 👍 started the job as gitpod-build-jenting-10887.1 |
0e5288a
to
f4dc1d7
Compare
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
sagor999
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold
for fixing log
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: workspace
Workspace team change is running in production
deployed
Change is completely running in production
release-note
size/M
team: workspace
Issue belongs to the Workspace team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We add an event to the workspace Pod in #10889 for the take volume snapshot operation (InProgress, ReadyToUse).
In this PR, we add an event to the workspace Pod when the PVC is restored from the VolumeSnapshot.
Hence, we would know the workspace Pod PVC is restored from the VolumeSnapshot or not.
Related Issue(s)
Fixes #10887
How to test
persistent_volume_claim
.dd if=/dev/urandom of=data bs=16M count=1
Release Notes
Documentation
N/A
Werft options: