Skip to content

[installer] Refactor configuration of addresses, metric and debug ports #11591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2022
Merged

[installer] Refactor configuration of addresses, metric and debug ports #11591

merged 1 commit into from
Jul 23, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 22, 2022 •
edited
Loading

Description

Replace arbitrary strings with go code and remove duplication.

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf aledbf changed the title [installer] Refactor configuration of localhost address, metric and d… [installer] Refactor configuration of addresses, metric and debug ports Jul 22, 2022
@aledbf aledbf force-pushed the aledbf/ref branch 4 times, most recently from ae64e75 to 925bba2 Compare July 22, 2022 21:39
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-ref.6 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review July 22, 2022 22:44
@aledbf aledbf requested review from a team July 22, 2022 22:44
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jul 22, 2022
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 22, 2022
geropl
geropl approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felladrin
felladrin approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed. Changes are clear.
I've also run a smoke test on VS Code Browser and GoLand and confirmed they're running fine.

@roboquat roboquat merged commit 14095f4 into main Jul 23, 2022
@roboquat roboquat deleted the aledbf/ref branch July 23, 2022 14:19
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels Jul 25, 2022
@ArthurSens ArthurSens mentioned this pull request Aug 1, 2022
Merged
1 task
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsimonemms mrsimonemms mrsimonemms approved these changes

@felladrin felladrin felladrin approved these changes

@geropl geropl geropl approved these changes

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/L team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aledbf @mrsimonemms @felladrin @geropl @jenting @roboquat