[usage] Allow selecting billed months #11617
Conversation
roboquat
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
size/M
size/L
and removed
size/M
labels
laushinka
force-pushed
the
lau/time-view-11526
branch
from
191deb7 to
6381a0b
Compare
laushinka
force-pushed
the
lau/time-view-11526
branch
from
a6d0586 to
17e7d34
Compare
laushinka
force-pushed
the
lau/time-view-11526
branch
3 times, most recently
from
058f78a to
2517be8
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
laushinka
force-pushed
the
lau/time-view-11526
branch
from
b584718 to
2b56493
Compare
| </defs> | ||
| </svg> | ||
| <span>{calculateTotalUsage()} Total Credits</span> | ||
| <CreditsSvg className="my-auto mr-1" /> |
There was a problem hiding this comment.
This is a drive-by improvement to extract the SVGs.
laushinka
force-pushed
the
lau/time-view-11526
branch
from
2b56493 to
7264a65
Compare
| for (let i = 1; i < 7; i++) { | ||
| const endDateVar = i - 1; | ||
| const startDate = new Date(today.getFullYear(), today.getMonth() - i); | ||
| const endDate = new Date(today.getFullYear(), today.getMonth() - endDateVar, 0); |
There was a problem hiding this comment.
Using this might make it easier logic vise. https://stackoverflow.com/questions/41505492/how-to-subtract-one-month-using-moment-js
I suspect the current logic has a bug for when 7 months back goes back to the previous year, as then you need to wrap the month and subtract 1 year
There was a problem hiding this comment.
You can test it by changing it to generate 12 months, or even 24 to see it
There was a problem hiding this comment.
I suspect the current logic has a bug for when 7 months back goes back to the previous year, as then you need to wrap the month and subtract 1 year
It actually computes it as expected! I tried going back 12 months from July 2022 and it correctly shows me as July 2021.
There was a problem hiding this comment.
I'm surprised! But the JS version of Date, which is based on Java 1.0 package actually allows you to subtract from dates by using negative months!
var now = new Date()
now
Wed Jul 27 2022 11:02:40 GMT+0200 (Central European Summer Time)
new Date(now.getFullYear(), now.getMonth() - 10, 0)
Tue Aug 31 2021 00:00:00 GMT+0200 (Central European Summer Time)
7264a65 to
422ab8b
Compare
Thanks! The functionality works but the list of months is much uglier than the dropdown. Since there are a bunch of other things that needs to be fixed, I'll unhold and move on to not block subsequent work, but I'm aware that we'll need to implement the dropdown or at least improve how it looks. |
roboquat
added
deployed: webapp
Description
Allows users to select billing months.
Related Issue(s)
Fixes #11526
How to test
Go to https://lau-time-view-11526.preview.gitpod-dev.com/t/gitpod/usage and click on the previous months.
Release Notes
Documentation
Werft options: