-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[supervisor]: gitpod config changed analytics #11653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
88d400b
to
0f9ac98
Compare
0f9ac98
to
085c57f
Compare
started the job as gitpod-build-ak-identiy-config-changed.5 because the annotations in the pull request description changed |
085c57f
to
185094b
Compare
started the job as gitpod-build-ak-identiy-config-changed.7 because the annotations in the pull request description changed |
185094b
to
3a6152d
Compare
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-ak-identiy-config-changed.9 |
8f75290
to
225a9b9
Compare
df87a24
to
327abfb
Compare
a745dcd
to
11f67f8
Compare
11f67f8
to
d6d2108
Compare
@@ -1,4 +1,4 @@ | |||
// Copyright (c) 2020 Gitpod GmbH. All rights reserved. | |||
// Copyright (c) 2022 Gitpod GmbH. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file auto-generated. I added git hook which regenerates it on commit, see .pre-commit-config.yaml
"description": "Configure JVM options, for instance '-Xmx=4096m'." | ||
} | ||
} | ||
"$ref": "#/definitions/jetbrainsProduct", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored to extract a common properties to the definition and stabilize code generation.
b47034b
to
86207ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as advertised 🎉
I left just a comment about events triggered when the workspace has no .gitpod.yml
and we run gp init
, which is an edge case.
let me verify first that it does not happen then a user creates an empty file as well, it does not look good |
86207ad
to
85cc185
Compare
@felladrin I pushed the fix when https://werft.gitpod-dev.com/job/gitpod-build-ak-identiy-config-changed.38 is ready you can try again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @akosyakov 🙏
It works as expected when the .gitpod.yml
is invalid. I've noticed that when creating with gp init
or deleting the whole file it does detect changes for each field but I'd say it's kind of expected and I don't consider it a bug.
@loujaybee @andreafalzetti Do you think it would be useful to add an attribute like |
Actually I'm wrong we cannot distinguish |
/unhold |
Description
This PR adds analytics for .gitpod.yml changes. We are track when changes are persisted to a disk and debounce them for 5s. After last change we analyse changes to top-level elements and report an event for each. It allows us to gain insights in what users are changing on top-level, e.g
ports
ortasks
, and avoid a lot of traffic at the same time. Later we can do more fine grained analysis to see which object properties, likeports.name
.I had to resolve couple issues which were discovered during review or were blocking testing:
Related Issue(s)
Fixes #6894
How to test
gitpod_config_changed
events.gitpod_config_changed
events.gitpod_config_changed
events.gitpod_config_changed
events for semantic changes.Check for regressions:
Release Notes
Documentation
Werft options: